Fix build with cc from Apple LLVM #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Xcode 4.x and above (I tested Xcode 4.6.3 on 10.7.5 and Xcode 5.5.1 on 10.9.2), cmake (2.8.12.2, whether from MacPorts or from clang.org, FWIW) is detecting /usr/bin/cc as Clang, but CMAKE_COMPILER_IS_CLANG is not getting set, so the tests aren't being built. (There may have been other build problems as well, but the fact that the tests weren't being built was by far the most obvious problem.) Checking the compiler ID detected by cmake, rather than the name of the command used to invoke the compiler, fixes this.
|
Merged in the developement branch for the next release. Thanks. |
hanno-becker
pushed a commit
to hanno-becker/mbedtls
that referenced
this pull request
Jan 21, 2021
Implement early data status
iameli
pushed a commit
to livepeer/mbedtls
that referenced
this pull request
Dec 5, 2023
Don't include AES-192 when compiling against BoringSSL.
iameli
pushed a commit
to livepeer/mbedtls
that referenced
this pull request
Dec 5, 2023
PR Mbed-TLS#93 added the SRTP_NO_AES192 macro and removed all references to AES-192 if it was set. The goal was to get libsrtp to compile with BoringSSL, which didn't support AES-192 at the time (Feb 2015). In the time since, BoringSSL has restored support for AES-192: https://boringssl.googlesource.com/boringssl/+/1049e26f https://boringssl.googlesource.com/boringssl/+/5dca031c Remove the SRTP_NO_AES192 macro, since it's no longer needed. Effectively reverts Mbed-TLS#93.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Xcode 4.x and above (I tested Xcode 4.6.3 on 10.7.5 and Xcode 5.5.1 on 10.9.2), cmake (2.8.12.2, whether from MacPorts or from clang.org, FWIW) is detecting /usr/bin/cc as Clang, but CMAKE_COMPILER_IS_CLANG is not getting set, so the tests aren't being built. (There may have been other build problems as well, but the fact that the tests weren't being built was by far the most obvious problem.)
Checking the compiler ID detected by cmake, rather than the name of the command used to invoke the compiler, fixes this.