-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto only CMake build system #9445
Add crypto only CMake build system #9445
Conversation
Since this touches |
yes indeed |
d85da81
to
8de9f9b
Compare
Signed-off-by: Ronald Cron <[email protected]>
Remove dependency on mbedtls_test_helpers to build the crypto test suites. mbedtls_test_helpers is TLS specific. Signed-off-by: Ronald Cron <[email protected]>
Move library options to the top CMakeLists.txt. That way: - we will be able to set the TF-PSA-Crypto library options according to the Mbed TLS ones. - we can define the crypto library target names in the top CMakeLists.txt and not in the library one that is dedicated to the TLS and x509 libraries now. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
They were mistakenly moved to the core directory from the library directory. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
…SA-Crypto ones Signed-off-by: Ronald Cron <[email protected]>
Copy of mbedtls top CMakeLists.txt file. The TF-PSA-Crypto top CMakeList.txt file will be derived from that file to outline what is common and what is different between the two. Signed-off-by: Ronald Cron <[email protected]>
Do not support package config, install, apidoc and lcov for the time being. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Remove framework and pkgconfig for the time being. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]> Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]> Signed-off-by: Minos Galanakis <[email protected]>
8de9f9b
to
393f9a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I have tested the out of source builds as well as the USE_SHARED_MBEDTLS_LIBRARY
combinations.
It also adds the capability to append custom configurations options to crypto_config file.
@@ -95,6 +96,19 @@ else() | |||
option(ENABLE_TESTING "Build Mbed TLS tests." ON) | |||
endif() | |||
|
|||
option(USE_STATIC_MBEDTLS_LIBRARY "Build Mbed TLS static library." ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note. Those parameter iterations were tested and confirmed locally on my machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix #9283
PR checklist