Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TLS auxiliary test scripts to the framework #9673

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Move TLS auxiliary test scripts to the framework #9673

merged 6 commits into from
Oct 17, 2024

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented Oct 7, 2024 •
edited
Loading

Description

Resolves Mbed-TLS/mbedtls-framework#54

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement needs-work size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Oct 7, 2024
@eleuzi01 eleuzi01 mentioned this pull request Oct 8, 2024
Merged
@eleuzi01 eleuzi01 force-pushed the issue-54-fw branch 2 times, most recently from 17ec7ae to 5b3b7e5 Compare October 8, 2024 15:54
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review and removed needs-work needs-ci Needs to pass CI tests labels Oct 8, 2024
@eleuzi01 eleuzi01 mentioned this pull request Oct 9, 2024
Merged
6 tasks
@eleuzi01 eleuzi01 added the needs-backports Backports are missing or are pending review and approval. label Oct 9, 2024
mpg
mpg previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mpg
mpg previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eleuzi01 eleuzi01 force-pushed the issue-54-fw branch 3 times, most recently from 0433a01 to 4b4c001 Compare October 15, 2024 10:37
@eleuzi01
Update submodule
7f7036e 
Signed-off-by: Elena Uziunaite <[email protected]>
@davidhorstmann-arm davidhorstmann-arm self-requested a review October 16, 2024 09:24
mpg
mpg previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidhorstmann-arm
davidhorstmann-arm previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm
Copy link
Contributor

This and #9675 need updating after the merge of Mbed-TLS/mbedtls-framework#56, ready to re-approve once that's done

@eleuzi01
Update submodule after the merge
8b6ee19 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01 eleuzi01 dismissed stale reviews from davidhorstmann-arm and mpg via 8b6ee19 October 16, 2024 14:00
gilles-peskine-arm
gilles-peskine-arm approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the last commit that updates the framework, based upon the the approval of 7f7036e by Manuel or by David.

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Oct 17, 2024
Merged
5 tasks
davidhorstmann-arm
davidhorstmann-arm approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Oct 17, 2024
Merged via the queue into Mbed-TLS:development with commit 13d2939 Oct 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@mpg mpg mpg left review comments

Assignees
No one assigned
Labels
enhancement needs-backports Backports are missing or are pending review and approval. needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move TLS auxiliary test scripts to the framework
4 participants
@eleuzi01 @davidhorstmann-arm @mpg @gilles-peskine-arm