Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Move check_files.py to the framework #9801

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Resolves Mbed-TLS/mbedtls-framework#72

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Nov 25, 2024
@eleuzi01 eleuzi01 force-pushed the issue-72-backport branch 4 times, most recently from 20cf5e2 to 25fb5c5 Compare November 29, 2024 16:30
@eleuzi01 eleuzi01 force-pushed the issue-72-backport branch 3 times, most recently from 18c3e83 to a3f6778 Compare December 10, 2024 15:11
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Dec 11, 2024
@valeriosetti valeriosetti self-requested a review December 13, 2024 13:55
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 19, 2024
@eleuzi01 eleuzi01 added the needs-ci Needs to pass CI tests label Dec 19, 2024
@minosgalanakis minosgalanakis removed the needs-ci Needs to pass CI tests label Dec 20, 2024
@minosgalanakis minosgalanakis added this pull request to the merge queue Dec 20, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit db07ce7 Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Development

Successfully merging this pull request may close these issues.

3 participants