Clean up doctrine deprecation warnings #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from 
|
What about the comment below on that issue ticket? |
|
It does seem to resolve this specific deprecation I think: |
melroy89
approved these changes
Aug 3, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue with
report_fields_where_declaredbeing set totrueand sequence generation by explicitly building with recommended identify generator preference ofGENERATOR_TYPE_SEQUENCE.Copied solution from: doctrine/orm#8893 (comment)
Also the
report_fields_where_declaredbeing set totrueissue noted here doctrine/orm#10953 (comment) seemed to be fixed by doctrine/orm#11050? @melroy89 can you review this, please?