Remove no longer supported CentOS 7 builds #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok if you skip CentOS 7 testing as CentOS 7 is out of support. RHEL 7 is still in support and in use though for several more years. We are still using PythonQt on RHEL 7 so please avoid making any breaking changes such as killing Qt 5.9 support or qmake support. It is practical to be able to use the same PythonQt version on all platforms (RHEL{7,8,9}; Ubuntu{20,22,24}.04LTS) and not having to have separate branching. Happy New Year to the PythonQt community! |
|
Sure - no sense in breaking compatibility if there is no real reason to that. This is only about the CI. Feel free to add more CI checks if you need them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node16 support has been completely removed from GH actions, together with CentOS 7 support, and the workaround no longer works.
There are more hacky workarounds to get it running again, but I'm reluctant to use them. Any installation on these systems should be fine using a released version - further changes in PythonQt will be most likely be related to Qt 6 only.
CC @he-hesce.