Add Q.ncall, like nfcall but accepts a thisArg #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm...i think the idiomatic naming convention would be ncall? see nbind and nfbind |
|
Ah makes sense, fixed! |
| @@ -42,7 +42,7 @@ if (typeof process !== 'undefined') { | |||
| * @param {Object|undefined} scope | |||
| * @param {Array} args | |||
| */ | |||
| function nextTickCallback (defer, callback, scope, args) { | |||
| function nextTickCallback(defer, callback, scope, args) { | |||
There was a problem hiding this comment.
Sorry for the ocd, I thought our style-guide only puts a space if it's an anonymous function, but now I can't find anything like that...
|
lg can you also update the README? |
kylehg
changed the title
kylehg
added a commit
that referenced
this pull request
Aug 24, 2015
Add Q.ncall, like nfcall but accepts a thisArg
|
Added a new release, ready for you to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nicks,
Please review the following commits I made in branch 'kyle-call'.
6598ada (2015-08-24 13:32:56 -0700)
Add Q.call, like nfcall but accepts a thisArg
R=@nicks
MANUAL TESTING=not manually tested