Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change border colors on the minimap for moved units #3733

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

mangofeet
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3733 (fe429a8) into master (57b2b85) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3733      +/-   ##
============================================
- Coverage     23.63%   23.63%   -0.01%     
  Complexity     4807     4807              
============================================
  Files          2204     2204              
  Lines        242602   242609       +7     
  Branches      45435    45436       +1     
============================================
  Hits          57341    57341              
- Misses       183806   183813       +7     
  Partials       1455     1455              
Impacted Files Coverage Δ
...k/src/megamek/client/ui/swing/minimap/Minimap.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b2b85...fe429a8. Read the comment docs.

@mangofeet
Copy link
Contributor Author

There are some color blindness issues in the Green-Blind/Deuteranopia and Monochromacy/Achromatopsia categories that I should sort out before this is merged

@mangofeet mangofeet force-pushed the minimap-moved-indication branch from a661ce4 to c88dc5f Compare June 24, 2022 21:27
@mangofeet mangofeet force-pushed the minimap-moved-indication branch from c88dc5f to b11abab Compare June 24, 2022 21:28
@HammerGS HammerGS requested a review from Windchild292 June 24, 2022 21:50
@mangofeet mangofeet changed the title Darken icons on the minimap for moved units Inver icon colors on the minimap for moved units Jun 24, 2022
@mangofeet mangofeet changed the title Inver icon colors on the minimap for moved units Invert icon colors on the minimap for moved units Jun 24, 2022
@mangofeet mangofeet changed the title Invert icon colors on the minimap for moved units Change border colors on the minimap for moved units Jun 24, 2022
Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spacing issue, which should probably be a float too

Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR

@Windchild292 Windchild292 merged commit a5f6497 into MegaMek:master Jun 25, 2022
@mangofeet mangofeet deleted the minimap-moved-indication branch June 25, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants