More sprites for #3118 list of missing ones #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit of the Guardian Fighter sprite to cover the Bullet Suicide Drone. The Guardian is the base chassis for the design.
Quick sprite of the Star Dagger following the art on Sarna.
Adds a 'Chassis' reference to Mechset so both Battle Taxi variants pick up the existing sprite.
Alliance space station sprite for MegaMek#3118. Mechset is for chassis, so both variants get it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5958 +/- ##
=========================================
Coverage 28.91% 28.91%
- Complexity 13941 13942 +1
=========================================
Files 2539 2539
Lines 268402 268402
Branches 47943 47943
=========================================
+ Hits 77603 77604 +1
Misses 186835 186835
+ Partials 3964 3963 -1 ☔ View full report in Codecov by Sentry. |
Not super happy with this one but better than no sprite. Might revisit this chassis in future.
|
Added the King Karnov as I had a bit of time. Not super happy with this sprite, so might come back to it in future and see if I can improve it. Better than no sprite though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the following 3 new sprites:
All are confirmed working in Megamek.
I've also modified the mechset entry for the Battle Taxi, so that the existing sprite is picked up for both variants.
Evidence:
Sprites added in this PR:
@HammerGS