Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5784: Better handling for missing parts when replacing parts via "Pod Space" #6015

Merged

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Feb 10, 2025

Fixes #5784

Another "Ghost" bug? It's pretty ghostly I think.

When using the "Pod Space" salvage for a busted location it would also remove "Missing Parts", so when the location is replaced there will be no option to repair the equipment that was a "Missing Part" at the time of the salvage task. This could be worked around be reloading after salvaging.

This fixes that by:

  1. Not removing "Missing Parts" when salvaging via Pod Space.
  2. Don't count "Missing Parts" as something that needs fixed (otherwise the repair pod space task would always show for missing limbs - this is why when salvaging parts it would show twice, first time would remove initial missing parts and present parts, 2nd salvage would remove the originally-present-now-missing-parts.)

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.34%. Comparing base (078a894) to head (91aa10e).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6015   +/-   ##
=========================================
  Coverage     10.33%   10.34%           
- Complexity     6130     6134    +4     
=========================================
  Files          1039     1039           
  Lines        139399   139404    +5     
  Branches      20675    20677    +2     
=========================================
+ Hits          14409    14415    +6     
- Misses       123542   123547    +5     
+ Partials       1448     1442    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 575bd28 into MegaMek:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]Omni parts not repairing or replacing properly nor showing as damaged
3 participants