Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache finances balance #6028

Merged
merged 5 commits into from
Feb 15, 2025
Merged

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Feb 13, 2025

My MekHQ was running slow - taking over 10 seconds to process a new day for a thicc Battalion while off contract. IntelliJ's profiler suggested that Finances::getBalance was taking a lot of time, so it's now cached.

Before caching:
image1
image

After caching:
image2

@psikomonkie
Copy link
Collaborator Author

Hey @IllianiCBT this is that PR we briefly chatted about!

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.36%. Comparing base (3f39021) to head (0087e25).
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6028      +/-   ##
============================================
+ Coverage     10.34%   10.36%   +0.01%     
- Complexity     6135     6150      +15     
============================================
  Files          1039     1040       +1     
  Lines        139412   139446      +34     
  Branches      20677    20684       +7     
============================================
+ Hits          14420    14450      +30     
+ Misses       123549   123542       -7     
- Partials       1443     1454      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Co-Pilot and IDEA AI no issues identified

@HammerGS HammerGS merged commit c2fb924 into MegaMek:master Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants