Packet speed #108
Open
Packet speed #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt and removed from packet
MegaRedHand
approved these changes
Jan 25, 2025
| // The longer the edge, the slower the progress increment | ||
| const normalizedSpeed = this.speed / edgeLength; | ||
|
|
||
| // Update progress with normalized speed | ||
| if (!Packet.animationPaused) { |
There was a problem hiding this comment.
We could have this be a speed of 0 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to control the speed of network simulations via a speed multiplier. The changes involve updating several files to incorporate this functionality, including the addition of a new
SpeedMultiplierclass, modifications to theGlobalContextandViewGraphclasses, and updates to the user interface to include a speed control slider.Key Changes:
Core Functionality:
SpeedMultiplierclass to manage speed values and provide utility methods for parsing and formatting (src/types/devices/speedMultiplier.ts).GlobalContextclass to handle speed multipliers, including methods to set and get the current speed, and to update the speed multiplier when loading the context (src/context.ts). [1] [2]View Graph:
ViewGraphclass to incorporate speed multipliers, including methods to set and get the speed, and to normalize packet speed based on edge length (src/types/graphs/viewgraph.ts). [1] [2]User Interface:
src/index.ejs,src/index.ts,src/styles/speed-wheel.css). [1] [2] [3]Persistence:
src/types/viewportManager.ts). [1] [2]