Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify distance, similarity, and uncertainty instantiation #13

Closed
thevolatilebit opened this issue Dec 2, 2023 · 0 comments
Closed

Unify distance, similarity, and uncertainty instantiation #13

thevolatilebit opened this issue Dec 2, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@thevolatilebit
Copy link
Collaborator

In CEEDesigns.GenerativeDesigns, while "distances" and "similarities" are provided by a user through a function call, an "uncertainty" is given as a type. See the following for reference:

DistanceBased(
data[!, ["RestingBP", "MaxHR", "Cholesterol", "FastingBS", "HeartDisease"]]; # the Mahalanobis distance only works with numeric features, so we selected a few, along with the target variable
target = "HeartDisease",
uncertainty = Entropy,
similarity = Exponential(; λ = 5),
distance = MahalanobisDistance(; diagonal = 1),
);

It may be worth unifying the style.

@thevolatilebit thevolatilebit added the enhancement New feature or request label Dec 2, 2023
@thevolatilebit thevolatilebit self-assigned this Dec 2, 2023
thevolatilebit added a commit that referenced this issue Dec 3, 2023
Optimizes code in `distancebased.jl`.

Changes the way that an "uncertainty" is provided. That is,
while "distances" and "similarities" are provided by a user through
 a function call, an "uncertainty" was originally given as a type.

Fixes #13
thevolatilebit added a commit that referenced this issue Dec 3, 2023
Improved documentation and added multiple fixes.

- Changed the way that an "uncertainty" is provided. That is,
while "distances" and "similarities" are provided by a user through
 a function call, an "uncertainty" was originally given as a type. (#13)

- Optimized computations in `distance based.jl` (#11)

- Implemented a variant of sq. Mahalanobis distance
with missing entries, see https://www.jstor.org/stable/3559861
on page 285, fixes #12

- Renamed `MahalanobisDistance` to `SquaredMahalanobisDistance`

Fixes #11, #12, and #13
---------

Co-authored-by: Bíma, Jan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant