Use tuple for tradeoff costs consistently #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevolatilebit
approved these changes
Nov 17, 2023
slwu89
added a commit
that referenced
this pull request
Nov 22, 2023
Consistent use of tuple for tradeoff costs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticDesigns.ArrangementMDPuses a tuple to store the tradeoff costs but both MDPs structs for generative designs used vectors. This PR makes sure that all MDP structs consistently use tuples for the tradeoff costs. Besides being more uniform in design, this is a very minor performance improvement and correctness check, as the length of the tradeoff "vector" cannot be longer than 2.