Don't print "All good!" when compilation is not "All good!" #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned out I wasn't ever setting the "compilation failed" variable where I expected it. Also I had a bug with the `BaseMatcher`, so I fixed it to be stricter about spans.
parsonsmatt
previously approved these changes
Dec 1, 2023
Gabriella439
approved these changes
Dec 4, 2023
|
|
||
| /// Test that `ghciwatch` can detect when compilation fails. | ||
| /// | ||
| /// Regression test for DUX-1649. |
There was a problem hiding this comment.
Perhaps create a matching GitHub issue that can be referenced here since this is an open source project (since outside contributors won't have access to our internal Linear).
9999years
deleted the
rebeccat/dux-1649-compilation-is-always-all-good-even-when-it-isnt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out I wasn't ever setting the "compilation failed" variable where I expected it.
Also I had a bug with the
BaseMatcher, so I fixed it to be stricter about spans.