TUI: Follow output when scrolled to the bottom #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
rebeccat/dux-1987-tui-follow-output-when-scrolled-to-bottom
branch
from
129760d to
92fd614
Compare
9999years
force-pushed
the
rebeccat/dux-1987-tui-follow-output-when-scrolled-to-bottom
branch
from
92fd614 to
5d63561
Compare
evanrelf
requested changes
Mar 1, 2024
src/tui/mod.rs
Outdated
| @@ -122,10 +122,18 @@ impl Tui { | |||
| self.scroll_offset = min(self.scroll_max(), scroll_offset); | |||
| } | |||
|
|
|||
| fn maybe_follow(&mut self) { | |||
| let height = self.size.height as usize; | |||
| if self.scroll_offset >= self.line_count - height - 1 { | |||
There was a problem hiding this comment.
Nit pick: I would add parens to make order of operations more obvious.
Suggested change
| if self.scroll_offset >= self.line_count - height - 1 { | |
| if self.scroll_offset >= self.line_count - (height + 1) { |
9999years
deleted the
rebeccat/dux-1987-tui-follow-output-when-scrolled-to-bottom
branch
evanrelf
reviewed
Mar 2, 2024
| } | ||
|
|
||
| impl Default for TuiState { | ||
| fn default() -> Self { | ||
| Self { | ||
| quit: false, | ||
| scrollback: Vec::with_capacity(TUI_SCROLLBACK_CAPACITY), | ||
| line_count: 1, | ||
| scroll_offset: 0, | ||
| line_count: Saturating(1), |
There was a problem hiding this comment.
lol you could go even further and make this a NonZeroUsize
There was a problem hiding this comment.
NonZeroUsize isn't saturating, weirdly: https://doc.rust-lang.org/stable/core/num/struct.NonZeroUsize.html#method.saturating_add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209.