Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate man pages #254

Merged
merged 1 commit into from
May 23, 2024
Merged

Generate man pages #254

merged 1 commit into from
May 23, 2024

Conversation

9999years
Copy link
Member

No description provided.

Copy link

linear bot commented May 20, 2024

DUX-2296 Man pages

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label May 20, 2024
@9999years 9999years force-pushed the rebeccat/dux-2296-man-pages branch from 2b4bfbe to 8adc8ab Compare May 22, 2024 18:36
@9999years 9999years marked this pull request as ready for review May 22, 2024 18:37
@9999years 9999years requested a review from Gabriella439 May 22, 2024 18:37
@9999years 9999years force-pushed the rebeccat/dux-2296-man-pages branch from 8adc8ab to 1a8113c Compare May 22, 2024 23:12
Comment on lines +294 to +296
# For some reason this is needed to strip references:
# stripping references to cargoVendorDir from share/man/man1/ghciwatch.1.gz
# sed: couldn't open temporary file share/man/man1/sedwVs75O: Permission denied
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, you can use install instead of cp since install supports setting permissions as part of copying, I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install doesn't support recursively copying directories so you have to bring in find too, not sure it's worth it.

@9999years 9999years merged commit 490d195 into main May 23, 2024
32 checks passed
@9999years 9999years deleted the rebeccat/dux-2296-man-pages branch May 23, 2024 22:08
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants