Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFCI] Module -> CompilingModule #289

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[NFCI] Module -> CompilingModule #289

merged 1 commit into from
Jun 13, 2024

Conversation

9999years
Copy link
Member

This is the result of parsing a GHC message like

[1 of 3] Compiling Foo ( Foo.hs, Foo.o, interpreted )

It is specifically for when a module is being compiled. In the future, we may parse out output names, the "1 of 3" bit, etc.

I'm thinking about adding a more complete Module type to go in the ModuleSet and I don't want name conflicts.

This is the result of parsing a GHC message like

    [1 of 3] Compiling Foo ( Foo.hs, Foo.o, interpreted )

It is specifically for when a module is being compiled. In the future,
we may parse out output names, the "1 of 3" bit, etc.

I'm thinking about adding a more complete `Module` type to go in the
`ModuleSet` and I don't want name conflicts.
@9999years 9999years requested a review from Gabriella439 June 7, 2024 22:20
@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Jun 7, 2024
@9999years 9999years enabled auto-merge (squash) June 7, 2024 22:20
@9999years 9999years disabled auto-merge June 13, 2024 17:32
@9999years 9999years merged commit 0ea78a4 into main Jun 13, 2024
40 checks passed
@9999years 9999years deleted the rebeccat/rename-module branch June 13, 2024 17:32
@9999years 9999years removed the patch Bug fixes or non-functional changes label Jun 13, 2024
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant