Don't restart for removed or renamed modules #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
rebeccat/dux-2336-remove-modules-instead-of-restarting-ghci
branch
4 times, most recently
from
78df0b3 to
101cb5a
Compare
9999years
force-pushed
the
rebeccat/dux-2336-remove-modules-instead-of-restarting-ghci
branch
from
101cb5a to
d02745f
Compare
9999years
commented
Jun 10, 2024
9999years
commented
Jun 10, 2024
| .await | ||
| .expect("ghciwatch loads ghci"); | ||
|
|
||
| session.fs_mut().disable_load_bearing_sleep(); |
There was a problem hiding this comment.
This API is clumsy, the load bearing sleep value should be tied to the particular Fs instance, not shared.
9999years
commented
Jun 10, 2024
| modules | ||
| .iter() | ||
| .map(|path| { | ||
| self.module_import_name(show_paths, path) |
There was a problem hiding this comment.
These ModuleSet APIs are showing some strain, but it's not clear what to replace them with. I tried a few designs and didn't like the results.
Gabriella439
previously approved these changes
Jun 10, 2024
9999years
force-pushed
the
rebeccat/dux-2336-remove-modules-instead-of-restarting-ghci
branch
from
d02745f to
26cf79b
Compare
Ghcid crashes when modules are removed/renamed because all it can do to the underlying GHCi session is `:reload`, and a GHCi bug [1] means that the GHCi session will crash when this happens. Because ghciwatch tracks which files/modules are loaded in the session, it can accurately `:unadd` files from the session when they're removed on disk, without requiring the session be restared. This should speed up development. [1]: https://gitlab.haskell.org/ghc/ghc/-/issues/11596
9999years
force-pushed
the
rebeccat/dux-2336-remove-modules-instead-of-restarting-ghci
branch
from
26cf79b to
d66522a
Compare
9999years
deleted the
rebeccat/dux-2336-remove-modules-instead-of-restarting-ghci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ghcid crashes when modules are removed/renamed because all it can do to the underlying GHCi session is
:reload, and a GHCi bug means that the GHCi session will crash when this happens.Because ghciwatch tracks which files/modules are loaded in the session, it can accurately
:unaddfiles from the session when they're removed on disk, without requiring the session be restared.This should speed up development.
I'm going to cut 1.0 with this while we're at it.
patch,minor, ormajorto request a version bump when it's merged.docs/.tests/.