Fix incorrect auto-scroll/follow behavior in TUI #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was super spread out, and modifiers and codes weren't paired visually.
Separate keys for enabling and disabling, because holding the key down for too long counts as multiple inputs, and causes the debug info to flicker. Fix is straightforward - either ignore `KeyEventKind::Repeat`, or record a past `KeyEventKind::Press` and wait for a `KeyEventKind::Release` before toggling again - but that's too much work right now for this hacky debug thing.
evanrelf
changed the title
9999years
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to follow logs had a bug where it'd increment the scroll offset regardless of how much of the screen was filled, so on startup it would start "following", pushing the logs up off the top.
This PR adds a second check to wait until the logs have filled the screen before auto-incrementing the scroll offset to follow.
I also tweaked the formatting of the key mapping
matches to be more readable (IMO) and introduced a rudimentary debug status bar (hidden by default) which was essential for understanding this bug and fixing it.I've found keeping debug info like this readily available to be a huge boon when working on my text editor project. I recommend keeping this in the code, at least while the TUI is in an experimental stage. But I'm also happy to remove if you'd rather not include that change.
Commits are atomic; I recommend reviewing them individually.