-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully exit when ghci
exits
#95
Gracefully exit when ghci
exits
#95
Conversation
DUX-1385 Error when underlying process was killed
I got this output:
It's unclear that we should just boot-loop here. |
67bf6f0
to
86122e3
Compare
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
b8a1525
to
949420f
Compare
86122e3
to
dbe4a9d
Compare
949420f
to
0c2e98d
Compare
dbe4a9d
to
62bc7bf
Compare
0c2e98d
to
b9b6674
Compare
62bc7bf
to
e3224f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sort of thing tends to cause ghci
to fail and hit this code path? The reason I'm asking is to see if it's worth restarting ghci
instead of gracefully exiting, but what you have already looks good to me.
@Gabriella439 It's in the Linear ticket. Matt hit an OOM or something:
|
ah yeah in that case you probably wouldnt be able to recover by restarting |
e3224f3
to
b522b4e
Compare
The base branch was changed.
Note that this won't gracefully exit until a reload is triggered, though.