fix: inject buttons in the right place #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new merge box selector is too generic. We have to select a section with a precise selector. The conflict section is always injected so we can select it and get the parent element to inject Mergify's buttons. Fixes MRGFY-4504 Fixes #33 Change-Id: I1c4b9eee8537888d6c32758166afde76191f5a87
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
sileht
approved these changes
Dec 30, 2024
jd
approved these changes
Dec 30, 2024
mergify
bot
deleted the
devs/DouglasBlackwood/inject-in-right-container/I1c4b9eee8537888d6c32758166afde76191f5a87
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new merge box selector is too generic. We have to select a section with a precise selector. The conflict section is always injected so we can select it and get the parent element to inject Mergify's buttons.
Fixes MRGFY-4504
Fixes #33