Optimization to hot path method

- Replace HasFlag() calls with bitwise checks to avoid garbage generation in FindUserDefinedSymbol which gets called extremely frequently. On one test project this reduced garbage generation for a compile from 211MB to 128MB. This also speeds up the function quite a bit (367ms -> 153ms in the same test case as above) so in some cases it can help compile time on large scripts.
MerlinVR · Jan 30, 2021 · b8013fc · b8013fc
1 parent 26f9419
commit b8013fc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Assets/UdonSharp/Editor/UdonSharpSymbolTable.cs b/Assets/UdonSharp/Editor/UdonSharpSymbolTable.cs
@@ -852,8 +852,8 @@ public SymbolDefinition FindUserDefinedSymbol(string symbolName)
                 {
                     SymbolDefinition symbolDefinition = currentTable.symbolDefinitions[i];
 
-                    if (!symbolDefinition.declarationType.HasFlag(SymbolDeclTypeFlags.Internal) &&
-                        (!currentTable.IsGlobalSymbolTable || !symbolDefinition.declarationType.HasFlag(SymbolDeclTypeFlags.MethodParameter)) && // Method parameters are declared globally, but only valid in their current local scope
+                    if ((symbolDefinition.declarationType & SymbolDeclTypeFlags.Internal) == 0 &&
+                        (!currentTable.IsGlobalSymbolTable || (symbolDefinition.declarationType & SymbolDeclTypeFlags.MethodParameter) == 0) && // Method parameters are declared globally, but only valid in their current local scope
                         symbolDefinition.symbolOriginalName == symbolName)
                     {
                         return symbolDefinition;