Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/tools: Fixed names to m4a template generator #375

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Mar 17, 2023

Contribution description

Was changed the directory's name from m4a-generator to template_generator, also was fixed the source path of template_generator in the script m4a_installer.sh .

Testing procedure

You should has uninstalled pip and m4agen.
if previously has installed these tools

sudo pip uninstall m4agen
sudo apt remove pyhton3-pip

then run in the base directory:

make generate-example

Automatically, the makefile will offer you install pip and m4agen. Pip is offered as a dependency to run m4agen

Issues/PRs references

Fixes #334

@CW-75 CW-75 added this to the 0.22.12 milestone Mar 17, 2023
@CW-75 CW-75 requested a review from luisan00 March 17, 2023 16:18
@luisan00 luisan00 modified the milestones: 0.22.12, 0.23.06-rc2 Mar 20, 2023
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me, going ahead bro!

@CW-75 CW-75 merged commit 0d23b49 into Mesh4all:main Mar 20, 2023
@CW-75 CW-75 deleted the feature_m4agen branch March 20, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dist/tools/m4a-generator: ambiguous name
2 participants