-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/14nov #781
Merged
enicolasgomez
merged 22 commits into
feature/iframe-throttling-fix-rebase
from
fix/14nov
Nov 20, 2023
Merged
Fix/14nov #781
enicolasgomez
merged 22 commits into
feature/iframe-throttling-fix-rebase
from
fix/14nov
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a field content is deleted too quickly (before the sync mechanism happens), an exception is raised in the Python side. This behavior doesn't occur if you type a value in a field, wait a little bit that the sync happens, and delete it. What's happening is that the code related to the netpyne field tries to delete a key that doesn't exists yet (see the video below). The fix removes this behavior (see video below)
sync dev with master
Feature/netpyne 105
Feature/netpyne 106
Image compatibility with OSB tweaks
Fix issue with fast delete of field content
NETPYNE-184 fix dev deployment
a5c222e
into
feature/iframe-throttling-fix-rebase
0 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.