Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching from the Keycloak library #457

Closed
zsinnema opened this issue Mar 8, 2022 · 2 comments · Fixed by #458
Closed

Remove caching from the Keycloak library #457

zsinnema opened this issue Mar 8, 2022 · 2 comments · Fixed by #458
Assignees
Milestone

Comments

@zsinnema
Copy link
Contributor

zsinnema commented Mar 8, 2022

Currently the Keycloak library of Cloud Harness uses the cachetool cached decorator to cache some frequently called functions.

For some applications that is nice (calling many times the KC rest api).

This issue suggests to remove the caching from the core CH KC library and let the application decide how to optimize it.

@filippomc filippomc added this to the v1.0.0 milestone Mar 8, 2022
@filippomc
Copy link
Collaborator

Sharing the tests made by @zsinnema:

Tested 100 calls to get user with id (ac.get_user(user_id))
without cache it took 5.34 seconds, with cache 0.06 seconds
10 repeated calls:
0.06s vs 0.488s

@zsinnema
Copy link
Contributor Author

zsinnema commented Mar 8, 2022

see also #456

@zsinnema zsinnema added enhancement New feature or request new feature labels Mar 8, 2022
@zsinnema zsinnema self-assigned this Mar 8, 2022
filippomc added a commit that referenced this issue Mar 8, 2022
#457 feature removed the cached functions from keycloak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants