Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused database properties from generated values.yaml #498

Closed
filippomc opened this issue Jun 10, 2022 · 1 comment · Fixed by #581
Closed

Clean unused database properties from generated values.yaml #498

filippomc opened this issue Jun 10, 2022 · 1 comment · Fixed by #581
Assignees
Labels
Milestone

Comments

@filippomc
Copy link
Collaborator

filippomc commented Jun 10, 2022

Properties for databases are specified even if no database is selected. We this we want to remove the useless specifications when they are not needed

@aranega aranega self-assigned this Sep 7, 2022
@aranega
Copy link
Member

aranega commented Sep 7, 2022

When no database is used, should the configuration still own an empty entry for database?

Like, the values.yaml file should contains:

  • an empty database entry --> database: {} ?
  • a database entrty with a name and nothing else --> database: {name: appname-db} ?
  • no database entry ?

Also, writing tests I saw that even if I remove the entries from the helm_values during the process, some are added back by the HarnessMainConfig at the end.
This is not a problem for the deployment/values.yaml generation as the file generation is performed before the instance of HarnessMainConfig is created.
However, in the deployment directory, there is still some artifacts from others db that are here.
For example, if I have a project with no db, I still have deployment/files/db-mongo-backup.sh which is generated, as well as a lot of templates files in deployment/templates.
Should they be removed also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants