-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#451: model and types #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/451
…nto feature/451
filippomc
added
the
alert:deployment
Something may break in the scope of this issue/pr in existing deployments
label
Mar 7, 2022
…nto feature/451
zsinnema
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alert:deployment
Something may break in the scope of this issue/pr in existing deployments
enhancement
New feature or request
scope:python-runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #451
Implemented solution: model stubs have been added based on OpenApi specification, and these models have been used to refactor the relevant apis to include typing hints.
The solution is backwards compatible as the new models can be used with the dictionary api as well.
How to test this PR:
Most of the new functionality is test covered to be backwards compatible. Functionality based on the cloudharness Python library should work untouched if developed following the main develoment templates. The main functionality that may be affected is data serialization/deserialization.
Even if everything has been done to make this backwards compatible, it's a quite of a radical change so additional attention is needed on deployments.
The main change is the new dependency introduced on the cloudharness_models library: the installation process of cloudharness has been improved to accommodate the new library (and other future library additions).
Sanity checks:
Breaking changes (select one):
breaking-change
Possible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):