Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#513 chore: Add openapi generator requirements overrides #515

Merged
merged 4 commits into from
Jul 11, 2022
Merged

#513 chore: Add openapi generator requirements overrides #515

merged 4 commits into from
Jul 11, 2022

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Jul 8, 2022 •
edited
Loading

Closes #513

Implemented solution: Overrides openapi-generator requirements.txt with missing requirements

How to test this PR:

  • Follow the steps described in the issue.
  • Server should start instead of giving the error

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

@afonsobspinto afonsobspinto linked an issue Jul 8, 2022 that may be closed by this pull request
ImportError: cannot import name 'escape' from 'jinja2' #513
Closed
@afonsobspinto afonsobspinto requested a review from filippomc July 8, 2022 17:16
@afonsobspinto afonsobspinto marked this pull request as draft July 8, 2022 17:40
@afonsobspinto afonsobspinto marked this pull request as ready for review July 11, 2022 10:47
filippomc
filippomc reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment to address

tools/harness-application
with tempfile.TemporaryDirectory() as tmp_dirname:
copymergedir(os.path.join(HERE, APPLICATION_TEMPLATE_PATH, template_name), tmp_dirname)
merge_configuration_directories(app_path, tmp_dirname)
generate_server(app_path, tmp_dirname)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to remove the tmp path at the end (suggest to use try...finally to ensure it is deleted)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be happening automatically because I'm creating the temp folder using the context manager with

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, nice!

filippomc
filippomc approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

tools/harness-application
with tempfile.TemporaryDirectory() as tmp_dirname:
copymergedir(os.path.join(HERE, APPLICATION_TEMPLATE_PATH, template_name), tmp_dirname)
merge_configuration_directories(app_path, tmp_dirname)
generate_server(app_path, tmp_dirname)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, nice!

@filippomc filippomc merged commit 2e8af78 into feature/248 Jul 11, 2022
@filippomc filippomc deleted the feature/513 branch July 11, 2022 12:33
@afonsobspinto afonsobspinto mentioned this pull request Sep 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'escape' from 'jinja2'
2 participants
@afonsobspinto @filippomc