Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/538 #540

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Feature/538 #540

merged 4 commits into from
Jul 25, 2022

Conversation

zsinnema
Copy link
Contributor

@zsinnema zsinnema commented Jul 25, 2022

Closes #538

Implemented solution: safe guard around the k8s service initialisation

How to test this PR: recreate a microservice of the django-app template and test running ./manage.py runserver

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema self-assigned this Jul 25, 2022
@zsinnema zsinnema added this to the v2.0.0 milestone Jul 25, 2022
@zsinnema zsinnema requested a review from afonsobspinto July 25, 2022 14:06
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked both with minikube and locally

@zsinnema zsinnema merged commit 0c6f95b into develop Jul 25, 2022
@filippomc filippomc deleted the feature/538 branch July 25, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django app template bypass keycload client and roles creation + kafka topic listeners when running local
2 participants