Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#561 fix: add CSRF_TRUSTED_ORIGINS to fix CSRF admin issue #564

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

zsinnema
Copy link
Contributor

@zsinnema zsinnema commented Sep 8, 2022

Closes #561

Implemented solution: add CSRF_TRUSTED_ORIGINS setting

How to test this PR: install a CH Django based app, go to the admin and create a new record. If no CSRF failure then everything is correct

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema added bug Something isn't working scope:code-generation labels Sep 8, 2022
@zsinnema zsinnema added this to the v2.0.0 milestone Sep 8, 2022
@zsinnema zsinnema self-assigned this Sep 8, 2022
@zsinnema zsinnema requested a review from filippomc September 8, 2022 11:26
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zsinnema zsinnema marked this pull request as draft September 9, 2022 11:08
@zsinnema zsinnema marked this pull request as ready for review September 9, 2022 11:23
@zsinnema zsinnema merged commit 5400537 into develop Sep 9, 2022
@filippomc filippomc deleted the feature/561 branch September 13, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:code-generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable CSRF protection when gatekeeper is enabled on cloudharness-django generated apps
2 participants