Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/584 #585

Merged
merged 12 commits into from
Oct 11, 2022
Merged

Feature/584 #585

merged 12 commits into from
Oct 11, 2022

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Oct 6, 2022

Closes #584

Implemented solution:

  • Checks if accounts is present and if it is adds a new volume and mountPath for 'cloudharness-kc-accounts'

How to test this PR:

  • Unittests were added and previous ones updateded
  • Added api check to samples application

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

@afonsobspinto afonsobspinto marked this pull request as ready for review October 11, 2022 10:19
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.
Being kind of difficult to follow the changes due to the code formatter used

@filippomc filippomc merged commit 3e85d20 into release/2.0.0 Oct 11, 2022
@filippomc filippomc deleted the feature/584 branch October 11, 2022 10:28
@afonsobspinto afonsobspinto linked an issue Nov 4, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount secrets on argo workflow pods
2 participants