-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/592 Avoid doing the same repeated build in the dev/test pipelines #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippomc
added
the
alert:deployment
Something may break in the scope of this issue/pr in existing deployments
label
Mar 9, 2023
zsinnema
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #592
Closes #679 (minor change)
Implemented solution: Changed the way that tags have been assigned to applications. Now tags are created from
an hashing of the content and this is used to check if the image already exists in the registry.
Builds for images that already exist are skipped on Codefresh
How to test this PR: run twice the same pipeline to see that builds are not repeated.
Sanity checks:
Breaking changes (select one):
breaking-change
Possible deployment updates issues (select one):
alert:deployment
as the way images are tagged changed; also images that rely on data external to the cloned data won't be updated as previously (same was due to the codefresh cache btw)Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):