Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-force-graph to most recent version #131

Closed
lrebscher opened this issue Jul 23, 2021 · 1 comment · Fixed by #132
Closed

Update react-force-graph to most recent version #131

lrebscher opened this issue Jul 23, 2021 · 1 comment · Fixed by #132
Assignees
@lrebscher
Labels
bug Something isn't working

Comments

@lrebscher
Copy link
Contributor

lrebscher commented Jul 23, 2021 •
edited
Loading

Current version has an issue with bezier-js.

That was fixed in more recent version.

Have to test if Canvas and any other component that relies on threejs still works after bumping up the version
@lrebscher lrebscher added the bug Something isn't working label Jul 23, 2021
@lrebscher lrebscher self-assigned this Jul 26, 2021
lrebscher added a commit that referenced this issue Jul 26, 2021
@lrebscher
#131 Bump up react-force-graph version

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a19a0b9 
* Add sass from devDeps to deps since projects using this package will need it
* Add required resolutions for bezier-js and three
lrebscher added a commit that referenced this issue Jul 26, 2021
@lrebscher
#131 Extend README
385864a
lrebscher added a commit that referenced this issue Jul 26, 2021
@lrebscher
#131 Add dep resolutions to example app
228db4f
lrebscher added a commit that referenced this issue Jul 26, 2021
@lrebscher
#131 Add Graph component to example app
d62b94d
@lrebscher lrebscher linked a pull request Jul 26, 2021 that will close this issue
Feature/131 react force graph #132
Merged
@lrebscher
Copy link
Contributor Author

Update: this couldn't be solved by bumping up react-force-graph version, this is an issue between CRA app and bezier-js which we can't resolve.

Currently, the only workaround is to add a bezier-js resolution to the top-level project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrebscher lrebscher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/131 react force graph MetaCell/geppetto-meta
1 participant
@lrebscher