Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dicom viewer toolbar to be application specific #443

Open
afonsobspinto opened this issue Dec 12, 2022 · 0 comments · Fixed by #458
Open

Allow dicom viewer toolbar to be application specific #443

afonsobspinto opened this issue Dec 12, 2022 · 0 comments · Fixed by #458
Assignees
@afonsobspinto
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@afonsobspinto
Copy link
Member

Dicom Vieiwer component should not enforce the use of custom toolbar but rather use it only has a default value and allow applications to specify their own toolbar via props: https://github.com/MetaCell/geppetto-meta/blob/development/geppetto.js/geppetto-ui/src/dicom-viewer/DicomViewer.js#L721
@afonsobspinto afonsobspinto added the enhancement New feature or request label Dec 12, 2022
@afonsobspinto afonsobspinto self-assigned this Dec 12, 2022
@afonsobspinto afonsobspinto added the good first issue Good for newcomers label Dec 12, 2022
@afonsobspinto afonsobspinto mentioned this issue Dec 12, 2022
Open
afonsobspinto added a commit that referenced this issue Dec 12, 2022
@afonsobspinto
#443 feat: Add ability to customize DicomViewer toolbar
952a04e
@afonsobspinto afonsobspinto mentioned this issue Dec 12, 2022
Closed
@afonsobspinto afonsobspinto linked a pull request Dec 12, 2022 that will close this issue
Features/442 to 446 #449
Closed
afonsobspinto added a commit that referenced this issue Dec 20, 2022
@afonsobspinto
#443 feat: Add ability to customize DicomViewer toolbar
f7c562d
@afonsobspinto afonsobspinto mentioned this issue Dec 20, 2022
Merged
@afonsobspinto afonsobspinto linked a pull request Dec 20, 2022 that will close this issue
Features 443 and 444 #458
Merged
@afonsobspinto afonsobspinto removed a link to a pull request Dec 20, 2022
Features/442 to 446 #449
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afonsobspinto afonsobspinto

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features 443 and 444 MetaCell/geppetto-meta
1 participant
@afonsobspinto