Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the z rotation in 3D view raised in NetPyNE. The fix takes back some of the modification originally made by @afonsobspinto but that were partially merged at some point.
However, even including portion of code that were present on
master
, after a rotation on z axis, the 3D representation wasn't refreshed until another rotation/movement was applied as no change in the square distance between the previoulsy computed position of the 3D object and the new one was found. I forced it L478 inTrackballControl.js
, but perhaps it's not the best thing to do.cc: @afonsobspinto , you'll probably be the best person to know as you have way more skill than me related to 3D and three.js 😄