Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/areg-116 - antibody url BE and FE changes - only if permitted #225

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Mar 20, 2024

Jira Link - https://metacell.atlassian.net/browse/AREG-116

Rule -Get antibody URL only if permitted. RULES:
1. If user is creator of the antibody, return the URL.
2. Else return only if show_link is True.
  • Changed this rule in mapper BE - in dto layer. So this rule applies for all the APIs.

This would affect FE in a way that - if URL is null, it is replaced by the first vendor URL as shown below.
image

video demo

2024-03-19.19-36-26.mp4





Also fixes - https://metacell.atlassian.net/browse/AREG-115
(disable the column URL for filtering and sorting)

Also fixes - https://metacell.atlassian.net/browse/AREG-110
(added old RenderCellContent - hence no issue with the download or rendering)

Also Fixes a bug -
(when filtering by M2M relationship fields - it shows multiple objects of the same id - hence add - distinct() to address that.

@filippomc filippomc merged commit 5a8438b into develop Mar 20, 2024
@filippomc filippomc deleted the feature/areg-116 branch March 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants