-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/areg 126 #239
Merged
Merged
Feature/areg 126 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…body-registry into feature/AREG-126
self.curate_vendor_domains_for_antibody(ab.abId) | ||
ab = get_antibody(ab.abId, status=STATUS.QUEUE)[0] | ||
|
||
self.assertTrue("www.bdbiosciences.com" in ab.vendorUrl) |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
The string may be at an arbitrary position in the sanitized URL.
www.bdbiosciences.com
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link - https://metacell.atlassian.net/browse/AREG-126
Logic for set_vendor_from_name_url as following:
fixing the get after prefetch and select related. This failed the test before the fix.
@filippomc - about the mapper's get_vendor_domains.
Reconsider using @cache - as this returns outdated results and breaks the test for vendors.