Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKCAN-85 feat: implement changes to the autosave #118

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

Anto8819
Copy link
Contributor

@Anto8819 Anto8819 commented May 2, 2023

ticket SCKAN-85

SCKAN-85 disable autosave and add save onChange for dropdowns

SCKAN-85 feat: disable autosave and add saving onblur and onchange

SCKAN-85 implement autosave every 2 min for text fields-

Screen.Recording.2023-05-02.at.13.50.53.mov

SCKAN-85 disable autosave and add save onChange for dropdowns

SCKAN-85 feat: disable autosave and add saving onblur and onchange

SCKAN-85 implement autosave every 2 min for text fields-
@Anto8819 Anto8819 requested a review from ddelpiano May 2, 2023 12:04
@Anto8819 Anto8819 self-assigned this May 2, 2023
@ddelpiano ddelpiano requested a review from afonsobspinto May 3, 2023 12:18
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using setTimeout would be more efficient, opposed to the current setInterval implementation, because it doesn't cause additional re-renders of the component.
Would it be possible to change the implementation to use that instead?

@Anto8819
Copy link
Contributor Author

Anto8819 commented May 3, 2023

I think using setTimeout would be more efficient, opposed to the current setInterval implementation, because it doesn't cause additional re-renders of the component. Would it be possible to change the implementation to use that instead?

Done @afonsobspinto

@ddelpiano ddelpiano merged commit 5f2c693 into develop May 4, 2023
@ddelpiano ddelpiano deleted the SCKAN-85-c branch May 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants