-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/esckan-35 - KnowledgeStatement endpoint fixes #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forward connections it's one of the information we need, please re-include it. Thanks :)
question: Should we allow this endpoint to be accessible from any origin (enable CORS)? Specifically, will Explorer be able to make requests directly to this endpoint or will it need a proxy? |
Indeed @afonsobspinto! We do need to allow CORS. thanks! |
@afonsobspinto imo we don't need cors |
Edited the title and description of the PR to include the full scope of the fix for KS endpoint. |
About CORS from the docs. - https://github.com/adamchainz/django-cors-headers?tab=readme-ov-file#signals In our case, we don't use |
jira Link - update on -> https://metacell.atlassian.net/browse/ESCKAN-35
super(ConnectivityStatementSerializer, self).to_representation(instance)
/api/composer/knowledge-statement/
using django-cors-header's signals.