Feature/302 #311
Merged
Feature/302 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
500 is a number of statements that should be realistic for the export, note for @SimaoBolota-MetaCell for testing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://metacell.atlassian.net/browse/SCKAN-302
Eliminated N+1 query problem by using select_related and prefetch_related to fetch related objects in bulk before iterating over them.
Prefetched related data with filters by utilized Prefetch objects with filtered querysets for notes and tags.
Avoided conditional database calls in loops by replacing exists() checks followed by all() calls with a single fetch and a simple list check.
Exporting again the 140 statements that existed in the database @ddelpiano shared with me was tacking longer than 10 minutes before the changes. After it took 80.70 seconds:
2024-10-07 201242,420 - logs composer export.txt
I didn't individually check the export, but overall the content looks correct
2024-10-07 201242,420 - logs composer export.txt
Misc: