Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend implementation for Alert system #361

Merged
merged 12 commits into from
Dec 9, 2024

Conversation

Salam-Dalloul
Copy link
Contributor

No description provided.

@ddelpiano ddelpiano changed the title Feature/sckan 349 Frontend skeleton for Alert system Nov 26, 2024
@Salam-Dalloul Salam-Dalloul changed the title Frontend skeleton for Alert system Frontend implementation for Alert system Dec 3, 2024
@Salam-Dalloul Salam-Dalloul marked this pull request as ready for review December 3, 2024 15:01
const newIndex = updatedAlerts.length - 1;
setOpenFormIndex(newIndex);
setTimeout(() => {
const textArea = document.querySelectorAll(`#root_statement_alerts_0_text`);
Copy link
Member

@afonsobspinto afonsobspinto Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I would prefer that we don't rely on a hardcoded id to focus.

Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed privately, if it's easy I would prefer the useEffect implementation instead of the setTimeout

@ddelpiano ddelpiano merged commit bb6175c into feature/SCKAN-345 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants