Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCKAN chore: Define formatter rules #31

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

afonsobspinto
Copy link
Member

@D-GopalKrishna raised an issue privately with me to try to converge into using the same formatter so that PR's are easy to review. This PR specifies a small set of formatting rules and applies it. No code was changed, only formatting.

@afonsobspinto afonsobspinto marked this pull request as draft May 31, 2024 14:47
@afonsobspinto afonsobspinto marked this pull request as ready for review May 31, 2024 14:51
@D-GopalKrishna
Copy link

thanks @afonsobspinto ! this should be great! but quick question:- why can't we do this with plain .eslintrc.yml? Why prettier?

@afonsobspinto
Copy link
Member Author

thanks @afonsobspinto ! this should be great! but quick question:- why can't we do this with plain .eslintrc.yml? Why prettier?

Have a look at:
https://typescript-eslint.io/troubleshooting/formatting/#problems-with-using-linters-as-formatters

@ddelpiano ddelpiano merged commit 46e1145 into develop Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants