Feature/esckan 51 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/esckan-55
afonsobspinto
approved these changes
Jun 7, 2024
| setData(jsonData); | ||
| }) | ||
| .catch((error) => console.error('Error fetching data:', error)); | ||
| const dataToPull = { |
There was a problem hiding this comment.
Suggestion (non-blocking): Move this useEffect logic into a service file
| request.open( | ||
| 'GET', | ||
| SCKAN_DATABASE_SUMMARY_URL_LATEST + DATABASE_FILES[file], | ||
| false, |
There was a problem hiding this comment.
Note (non-blocking): Synchronous fetching is usually discouraged because it can lead to a poor user experience.
| }, []); | ||
|
|
||
| if (!data || !labels) | ||
| if (!loaded) |
There was a problem hiding this comment.
Note (non-blocking): My understanding is that the loader will never show given how we are fetching the data
| @@ -77,7 +224,7 @@ const SummaryPage = () => { | |||
| Database summary | |||
| </Typography> | |||
| <Typography variant="body1" color={gray500}> | |||
| Last updated on September 15, 2023 | |||
| Last updated on May 15, 2024 | |||
There was a problem hiding this comment.
Note (non-blocking): This update strategy seems very limiting in the sense that would require code changes everytime we want to update the content of this component. We will need to rethink this when we have a more concrete picture and more time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database connected to the json provided by Fahim - disclaimer, I bypassed the typing requirements since I am not sure this format will last and I don't have time atm if that changes.
CSV generation, this is a poc done for them to test it but again I am not sure it will last and mostly will be subject to changes, reason why the typing has been disabled for the file.