Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCKAN-73 Add population counter #66

Merged
merged 2 commits into from
Nov 22, 2024
Merged

ESCKAN-73 Add population counter #66

merged 2 commits into from
Nov 22, 2024

Conversation

dvcorreia
Copy link
Member

@dvcorreia dvcorreia commented Nov 14, 2024

The population filter (top-right of the left side widget) needs to be added. Beware of the fact that the counter needs to be updated if the filters are active.

Figma design

Current changes:

  • population counter add in connectivity grid, reusing the already implemented filterKnowledgeStatements function.

Warning

filterKnowledgeStatements does NOT account for the EndOrgan filter. Don't know if it is expected or not.

export-seg.mp4

@dvcorreia dvcorreia self-assigned this Nov 14, 2024
@dvcorreia dvcorreia requested a review from ddelpiano November 19, 2024 11:44
@dvcorreia dvcorreia marked this pull request as ready for review November 19, 2024 11:45
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddelpiano ddelpiano merged commit 3501313 into develop Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants