Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCKAN-75 Fix nerves filtering #69

Merged
merged 1 commit into from
Nov 18, 2024
Merged

ESCKAN-75 Fix nerves filtering #69

merged 1 commit into from
Nov 18, 2024

Conversation

dvcorreia
Copy link
Member

Current changes:

  • Each time we select a connection, in the context provider, it filters out anatomical entities that are not present in the neurons file provided by the client. This is propagated through the app, reflecting both in the PDF download and connections summary.

Another solution for this can be seen in develop...feature/ESCKAN-75.

@dvcorreia dvcorreia requested a review from ddelpiano November 18, 2024 15:44
@dvcorreia dvcorreia self-assigned this Nov 18, 2024
@dvcorreia
Copy link
Member Author

@ddelpiano changing this in the context provided may very well mess with something that I'm not aware in the application. I've read a bit of the code where it deals with the vias anatomical_entities, but I don't get a lot of the business logic, so I don't really get it. If this changes don't make sense, please let me know :)

Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddelpiano ddelpiano merged commit 3af25de into develop Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants