Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Increase minimum Node.js version to 16; recommended to 18 #52

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 14, 2023

  • BREAKING: remove support for major node versions 14-15,17,19
    • ci: run on node v20 instead of v14
    • set .nvmrc to v18 (thereby changing default ci node version)
    • docs: change recommended node version from v14 to v18

@legobeat legobeat marked this pull request as ready for review November 14, 2023 13:07
@legobeat legobeat requested review from a team as code owners November 14, 2023 13:07
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

- ci: run on node 20 instead of 14
- remove support for major node versions 14-15,17,19
- set .nvmrc to v18 (thereby changing default ci node version)
@legobeat legobeat merged commit d6157bc into MetaMask:main Nov 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants