Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 #1092

Merged
merged 4 commits into from
Sep 23, 2022
Merged

2.0.0 #1092

merged 4 commits into from
Sep 23, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 2.0.0.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
Comment on lines 41 to 42
[2.0.0]: https://github.com/MetaMask/contract-metadata/compare/v1.37.0...v2.0.0
[1.37.0]: https://github.com/MetaMask/contract-metadata/compare/v1.36.0...v1.37.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the now non-existent v1.3.7 release is still here at the bottom. Here is how to replace it:

Suggested change
[2.0.0]: https://github.com/MetaMask/contract-metadata/compare/v1.37.0...v2.0.0
[1.37.0]: https://github.com/MetaMask/contract-metadata/compare/v1.36.0...v1.37.0
[2.0.0]: https://github.com/MetaMask/contract-metadata/compare/v1.36.0...v2.0.0

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of minor changes suggested, then I can approve

CHANGELOG.md Outdated
## [1.37.0]
### Uncategorized
## [2.0.0]
### Additions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the KeepAChangelog format uses the title "Added" for this section

Suggested change
### Additions
### Added

CHANGELOG.md Outdated
- Add Quid Ika Token ([#1043](https://github.com/MetaMask/contract-metadata/pull/1043))

### Changed
### Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The KeepAChangelog format uses the title "Changed" for this section

Suggested change
### Changes
### Changed

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt marked this pull request as ready for review September 23, 2022 13:06
@Gudahtt Gudahtt requested a review from a team as a code owner September 23, 2022 13:06
@MRabenda MRabenda merged commit 666d47c into master Sep 23, 2022
@MRabenda MRabenda deleted the release/2.0.0 branch September 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants