Skip to content

Commit

Permalink
feat: use new scopes from KeyringAccount
Browse files Browse the repository at this point in the history
  • Loading branch information
ccharly committed Jan 6, 2025
1 parent 3bd40d3 commit e7409ab
Show file tree
Hide file tree
Showing 7 changed files with 71 additions and 56 deletions.
4 changes: 2 additions & 2 deletions packages/accounts-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"@ethereumjs/util": "^8.1.0",
"@metamask/base-controller": "^7.1.0",
"@metamask/eth-snap-keyring": "^7.0.0",
"@metamask/keyring-api": "^12.0.0",
"@metamask/keyring-internal-api": "^1.0.0",
"@metamask/keyring-api": "^13.0.0",
"@metamask/keyring-internal-api": "^1.1.0",
"@metamask/snaps-sdk": "^6.7.0",
"@metamask/snaps-utils": "^8.3.0",
"@metamask/utils": "^11.0.1",
Expand Down
4 changes: 4 additions & 0 deletions packages/accounts-controller/src/AccountsController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { SnapKeyring } from '@metamask/eth-snap-keyring';
import {
EthAccountType,
EthMethod,
EthScopes,
isEvmAccountType,
} from '@metamask/keyring-api';
import { KeyringTypes } from '@metamask/keyring-controller';
Expand Down Expand Up @@ -203,6 +204,7 @@ export const EMPTY_ACCOUNT = {
options: {},
methods: [],
type: EthAccountType.Eoa,
scopes: [EthScopes.Namespace],
metadata: {
name: '',
keyring: {
Expand Down Expand Up @@ -582,6 +584,7 @@ export class AccountsController extends BaseController<
EthMethod.SignTypedDataV3,
EthMethod.SignTypedDataV4,
],
scopes: [EthScopes.Namespace],
type: EthAccountType.Eoa,
metadata: {
name: '',
Expand Down Expand Up @@ -656,6 +659,7 @@ export class AccountsController extends BaseController<
EthMethod.SignTypedDataV3,
EthMethod.SignTypedDataV4,
],
scopes: [EthScopes.Namespace],
type: EthAccountType.Eoa,
metadata: {
name: this.#populateExistingMetadata(id, 'name') ?? '',
Expand Down
2 changes: 1 addition & 1 deletion packages/assets-controllers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"@metamask/auto-changelog": "^3.4.4",
"@metamask/ethjs-provider-http": "^0.3.0",
"@metamask/keyring-controller": "^19.0.2",
"@metamask/keyring-internal-api": "^1.0.0",
"@metamask/keyring-internal-api": "^1.1.0",
"@metamask/network-controller": "^22.1.1",
"@metamask/preferences-controller": "^15.0.1",
"@metamask/providers": "^18.1.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/chain-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"dependencies": {
"@metamask/base-controller": "^7.1.0",
"@metamask/chain-api": "^0.1.0",
"@metamask/keyring-internal-api": "^1.0.0",
"@metamask/keyring-internal-api": "^1.1.0",
"@metamask/keyring-utils": "^1.0.0",
"@metamask/snaps-controllers": "^9.10.0",
"@metamask/snaps-sdk": "^6.7.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/keyring-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"@metamask/eth-hd-keyring": "^7.0.4",
"@metamask/eth-sig-util": "^8.0.0",
"@metamask/eth-simple-keyring": "^6.0.5",
"@metamask/keyring-api": "^12.0.0",
"@metamask/keyring-internal-api": "^1.0.0",
"@metamask/keyring-api": "^13.0.0",
"@metamask/keyring-internal-api": "^1.1.0",
"@metamask/message-manager": "^11.0.3",
"@metamask/utils": "^11.0.1",
"async-mutex": "^0.5.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/profile-sync-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
},
"dependencies": {
"@metamask/base-controller": "^7.1.0",
"@metamask/keyring-api": "^12.0.0",
"@metamask/keyring-api": "^13.0.0",
"@metamask/keyring-controller": "^19.0.2",
"@metamask/network-controller": "^22.1.1",
"@metamask/snaps-sdk": "^6.7.0",
Expand All @@ -117,7 +117,7 @@
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/accounts-controller": "^20.0.2",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-internal-api": "^1.0.0",
"@metamask/keyring-internal-api": "^1.1.0",
"@metamask/providers": "^18.1.1",
"@metamask/snaps-controllers": "^9.10.0",
"@types/jest": "^27.4.1",
Expand Down
107 changes: 59 additions & 48 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2194,6 +2194,16 @@ __metadata:
languageName: node
linkType: hard

"@metamask/abi-utils@npm:^3.0.0":
version: 3.0.0
resolution: "@metamask/abi-utils@npm:3.0.0"
dependencies:
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^11.0.1"
checksum: 10/068b98185148b9e185b4af4392c6a6f82f1d4b1ff60013c57679c618f37afe9030e3ccc940e1a8b690be6f62ea91115ab18b73f3c3c09f4eff1794e31ababb9b
languageName: node
linkType: hard

"@metamask/accounts-controller@npm:^20.0.2, @metamask/accounts-controller@workspace:packages/accounts-controller":
version: 0.0.0-use.local
resolution: "@metamask/accounts-controller@workspace:packages/accounts-controller"
Expand All @@ -2202,9 +2212,9 @@ __metadata:
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.1.0"
"@metamask/eth-snap-keyring": "npm:^7.0.0"
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-controller": "npm:^19.0.2"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
Expand Down Expand Up @@ -2323,7 +2333,7 @@ __metadata:
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/ethjs-provider-http": "npm:^0.3.0"
"@metamask/keyring-controller": "npm:^19.0.2"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/metamask-eth-abis": "npm:^3.1.1"
"@metamask/network-controller": "npm:^22.1.1"
"@metamask/polling-controller": "npm:^12.0.2"
Expand Down Expand Up @@ -2459,7 +2469,7 @@ __metadata:
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.1.0"
"@metamask/chain-api": "npm:^0.1.0"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
Expand Down Expand Up @@ -2809,17 +2819,17 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eth-sig-util@npm:^8.0.0":
version: 8.1.0
resolution: "@metamask/eth-sig-util@npm:8.1.0"
"@metamask/eth-sig-util@npm:^8.0.0, @metamask/eth-sig-util@npm:^8.1.2":
version: 8.1.2
resolution: "@metamask/eth-sig-util@npm:8.1.2"
dependencies:
"@ethereumjs/util": "npm:^8.1.0"
"@metamask/abi-utils": "npm:^2.0.4"
"@metamask/utils": "npm:^9.0.0"
"@metamask/abi-utils": "npm:^3.0.0"
"@metamask/utils": "npm:^11.0.1"
"@scure/base": "npm:~1.1.3"
ethereum-cryptography: "npm:^2.1.2"
tweetnacl: "npm:^1.0.3"
checksum: 10/6e8abca5c0431ca8e0a3b6c3654cf864bf54a484c2888ebc639e6a44767564c45e25da77664e55ffc65b3abbec55902813d4a57d85ffc097706cffd1c9d37dde
checksum: 10/32b284fc8c3229e3741b1c21f44ca3f55c2215ef8ad700775cd9501bbaab56a4e861827bef24ed263734d28c899eb3b34a9646e9d21ec3fce12204b7eb58bfed
languageName: node
linkType: hard

Expand All @@ -2837,26 +2847,27 @@ __metadata:
linkType: hard

"@metamask/eth-snap-keyring@npm:^7.0.0":
version: 7.0.0
resolution: "@metamask/eth-snap-keyring@npm:7.0.0"
version: 7.1.0
resolution: "@metamask/eth-snap-keyring@npm:7.1.0"
dependencies:
"@ethereumjs/tx": "npm:^4.2.0"
"@metamask/eth-sig-util": "npm:^8.0.0"
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-internal-snap-client": "npm:^1.0.0"
"@metamask/eth-sig-util": "npm:^8.1.2"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/keyring-internal-snap-client": "npm:^1.1.0"
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^9.3.0"
"@metamask/utils": "npm:^11.0.1"
"@types/uuid": "npm:^9.0.8"
uuid: "npm:^9.0.1"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/keyring-api": ^12.0.0
"@metamask/providers": ^18.1.0
checksum: 10/7a82cd2c19204776d31e29716844ac6f304ce4b136b36728be8e7b19ac2be6b46d0c72cc9707c48669a7a342994ce401aafbfe3f0b47769748ab86ae2169cbbd
"@metamask/keyring-api": ^13.0.0
"@metamask/providers": ^18.3.1
checksum: 10/0cfa24d5ad2f0ec83d096de906c48994994b2af999cdd7ab6a472aa9c96c1ceab1f800588f4cdc6f9a2c6821417772321c1a031fead53a5c61c792a6adea839f
languageName: node
linkType: hard

Expand Down Expand Up @@ -3113,15 +3124,15 @@ __metadata:
languageName: node
linkType: hard

"@metamask/keyring-api@npm:^12.0.0":
version: 12.0.0
resolution: "@metamask/keyring-api@npm:12.0.0"
"@metamask/keyring-api@npm:^13.0.0":
version: 13.0.0
resolution: "@metamask/keyring-api@npm:13.0.0"
dependencies:
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^9.3.0"
"@metamask/utils": "npm:^11.0.1"
bech32: "npm:^2.0.0"
checksum: 10/ba8b75c55d3fcb9f8b52c58ff141cba81f7c416c3fa684e089965717ea129d50e8df7a73e7ab1c96eaf59d70b6e2dd8a618434939b75ef0d3402b547b5196877
checksum: 10/f7e8982112a2813790354267af8f79cbf241d7ca9d733fe5e8de1a13993203b154ac6d358a92bd4340cbd4d25f4bac48681d17a25e3dc6f2336c95c00c371686
languageName: node
linkType: hard

Expand All @@ -3142,8 +3153,8 @@ __metadata:
"@metamask/eth-hd-keyring": "npm:^7.0.4"
"@metamask/eth-sig-util": "npm:^8.0.0"
"@metamask/eth-simple-keyring": "npm:^6.0.5"
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/message-manager": "npm:^11.0.3"
"@metamask/scure-bip39": "npm:^2.1.1"
"@metamask/utils": "npm:^11.0.1"
Expand All @@ -3163,48 +3174,48 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/keyring-internal-api@npm:^1.0.0":
version: 1.0.0
resolution: "@metamask/keyring-internal-api@npm:1.0.0"
"@metamask/keyring-internal-api@npm:^1.1.0":
version: 1.1.0
resolution: "@metamask/keyring-internal-api@npm:1.1.0"
dependencies:
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^9.3.0"
checksum: 10/dd0fff93ddfdce008f1db82d404bd040d09840413723c831819d3a7f4c2819a4303657e4acd7578cfd22bd05ad9c7aa563fc88f13f2f06999e2325ada71b824c
"@metamask/utils": "npm:^11.0.1"
checksum: 10/5db127cfe319c289b95d55d08b6737820f00761564e219d756a55e030b83043fb43d18bac3b63fcc69cd2e03129f831410ce960ba954d8183d976d87a6781b8c
languageName: node
linkType: hard

"@metamask/keyring-internal-snap-client@npm:^1.0.0":
version: 1.0.0
resolution: "@metamask/keyring-internal-snap-client@npm:1.0.0"
"@metamask/keyring-internal-snap-client@npm:^1.1.0":
version: 1.1.0
resolution: "@metamask/keyring-internal-snap-client@npm:1.1.0"
dependencies:
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-snap-client": "npm:^1.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-snap-client": "npm:^1.1.0"
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/providers": ^18.1.0
checksum: 10/4c02429235bf5b3609fe2d728f0f976fc87cc276483c092d155b181eeb1f167953a96226c4f6b64f6700084f8a66e5b02944ba0accf201e3514e83df205389e1
"@metamask/providers": ^18.3.1
checksum: 10/58e0f00cc3798b156b7e2b3766216a8b355970391a33c9fb4b31cffc7c06d77cf63be275e5e217e0e05c517ed01dd8745b202882d6b7dd14891115d1dd022b7a
languageName: node
linkType: hard

"@metamask/keyring-snap-client@npm:^1.0.0":
version: 1.0.0
resolution: "@metamask/keyring-snap-client@npm:1.0.0"
"@metamask/keyring-snap-client@npm:^1.1.0":
version: 1.1.0
resolution: "@metamask/keyring-snap-client@npm:1.1.0"
dependencies:
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-utils": "npm:^1.0.0"
"@metamask/superstruct": "npm:^3.1.0"
"@types/uuid": "npm:^9.0.8"
uuid: "npm:^9.0.1"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/providers": ^18.1.0
checksum: 10/7b3ee4ab6b39f8e06d55dee2c29f778eeb2eeb8bb311eccaab07d1f8a855fa920bf52e78bd2be0f3ddcb66dc475282d740de0cc7337ccd99e956302a706d76a0
"@metamask/providers": ^18.3.1
checksum: 10/f6e72d94d2fefd24619eca8c6fe838e448adbc42553656a4ffac44c32266836eb8223b30881c70434ce88e433c6fce12dbdaf9920dca7542b54334802cff72b7
languageName: node
linkType: hard

Expand Down Expand Up @@ -3563,9 +3574,9 @@ __metadata:
"@metamask/accounts-controller": "npm:^20.0.2"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.1.0"
"@metamask/keyring-api": "npm:^12.0.0"
"@metamask/keyring-api": "npm:^13.0.0"
"@metamask/keyring-controller": "npm:^19.0.2"
"@metamask/keyring-internal-api": "npm:^1.0.0"
"@metamask/keyring-internal-api": "npm:^1.1.0"
"@metamask/network-controller": "npm:^22.1.1"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
Expand Down

0 comments on commit e7409ab

Please sign in to comment.