Enable detection of arbitrary number of tokens in batches of 1000

- Fixes #3661 Co-authored-by: Brian Bergeron <[email protected]>
MetaMask · Feb 27, 2024 · f060ced · f060ced
1 parent a09fcda
commit f060ced
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/assets-controllers/CHANGELOG.md b/packages/assets-controllers/CHANGELOG.md
@@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - **BREAKING:** In Mainnet, even if the `PreferenceController`'s `useTokenDetection` option is set to false, automatic token detection is performed on the legacy token list (token data from the contract-metadata repo).
   - **BREAKING:** The `TokensState` type is now defined as a type alias rather than an interface. ([#3690](https://github.com/MetaMask/core/pull/3690/))
     - `TokensState` now extends the `Record` types, and it has an index signature of `string`, making it compatible with the `BaseControllerV2` state object constraint of `Record<string, Json>`.
+  - The `detectTokens` method can now process an arbitrary number of tokens in batches of 1000.
 
 ### Removed
 

diff --git a/packages/assets-controllers/jest.config.js b/packages/assets-controllers/jest.config.js
@@ -19,8 +19,8 @@ module.exports = merge(baseConfig, {
     global: {
       branches: 88.38,
       functions: 96.98,
-      lines: 97.37,
-      statements: 97.42,
+      lines: 97.31,
+      statements: 97.37,
     },
   },
 

diff --git a/packages/assets-controllers/src/TokenDetectionController.ts b/packages/assets-controllers/src/TokenDetectionController.ts
@@ -566,11 +566,9 @@ export class TokenDetectionController extends StaticIntervalPollingController<
     }
 
     const slicesOfTokensToDetect = [];
-    slicesOfTokensToDetect[0] = tokensToDetect.slice(0, 1000);
-    slicesOfTokensToDetect[1] = tokensToDetect.slice(
-      1000,
-      tokensToDetect.length - 1,
-    );
+    for (let i = 0, size = 1000; i < tokensToDetect.length; i += size) {
+      slicesOfTokensToDetect.push(tokensToDetect.slice(i, i + size));
+    }
 
     return slicesOfTokensToDetect;
   }